Conversation
havogt
left a comment
There was a problem hiding this comment.
Thanks for the fix! With the suggested change, my use-case would be covered as well. I tested a few cases and seems good.
|
Note, unrelated to this PR I opened #1021 which might result in weird errors if you run into the problem. |
|
In #1004 I would consider |
jcanton
left a comment
There was a problem hiding this comment.
looks good to me, also tested locally and works
ok, but I can make this change in PR1004, not here |
90c02c1 to
ebaab87
Compare
havogt
left a comment
There was a problem hiding this comment.
Tested and works (including the muphys use-case).
Co-authored-by: Hannes Vogt <hannes@havogt.de>
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
To run test levels ignored by the default test suite (mostly simple datatest for static fields computations) you can use:
For more detailed information please look at CI in the EXCLAIM universe. |
Attempting to fix data downloads after #1002.
With my current understanding of how the downloads work, the download and extraction should happen in the "root" directory (
_ranked_data_path), but the tarball actually contains subdirectories which match the experiment-specific subdirectory (which is what we check for to see if the data already exists).I've tested re-downloading one grid and that worked. Please test it on your local setups to see I haven't messed something up.